Skip to content

Select: add min-width to portal so menu remains usable with small triggers#144

Merged
jaruesink merged 2 commits into
mainfrom
codegen-bot/select-portal-min-width-0c8b2a
Sep 19, 2025
Merged

Select: add min-width to portal so menu remains usable with small triggers#144
jaruesink merged 2 commits into
mainfrom
codegen-bot/select-portal-min-width-0c8b2a

Conversation

@codegen-sh
Copy link
Copy Markdown
Contributor

@codegen-sh codegen-sh Bot commented Sep 19, 2025

Summary

  • Ensures the Select portal grows with the trigger width but always maintains a sensible minimum width for usability
  • Keeps width synced to the trigger via --radix-popover-trigger-width; adds Tailwind min-w-[8rem] so very small triggers still render a readable menu

Change details

  • UI: packages/components/src/ui/select.tsx — add min-w-[8rem] to Popover.Content while preserving width: var(--radix-popover-trigger-width)

Why

  • Recent refactors removed the min width and small triggers could result in an unusably narrow menu

Requested by: Jake Ruesink


💻 View my workAbout Codegen
⛔ Remove Codegen from PR🚫 Ban action checks

…width (min-w-[8rem])\n\nAdds min-width to Popover.Content so the Select portal remains usable even when the trigger is very small. Width still tracks the trigger via --radix-popover-trigger-width.\n\nRequested by: Jake Ruesink
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Copy Markdown
Contributor

📝 Storybook Preview: View Storybook

This preview will be updated automatically when you push new changes to this PR.

Note: The preview will be available after the workflow completes and the PR is approved for deployment.

@jaruesink
Copy link
Copy Markdown
Contributor

jaruesink commented Sep 19, 2025

@codegen-sh let's use npm to add a patch version to our components package, don't publish just bump the patch version and push up to this same branch codegen-bot/select-portal-min-width-0c8b2a

Got it! I'll bump the patch version and push to the branch. 🔧

💻 View my work🛑 Stop

…nVersion bump only (no publish). Requested by: Jake Ruesink
@codegen-sh
Copy link
Copy Markdown
Contributor Author

codegen-sh Bot commented Sep 19, 2025

Bumped @lambdacurry/forms patch version to 0.20.1 (no publish), requested by Jake Ruesink.

@codegen-sh
Copy link
Copy Markdown
Contributor Author

codegen-sh Bot commented Sep 19, 2025

Patch version bumped with npm and pushed ✅

  • Ran npm version patch --no-git-tag-version in packages/components to bump @lambdacurry/forms from 0.20.0 → 0.20.1
  • Committed and pushed to the same branch
  • Left a note on the PR

🔄 View Updated PR #144 on Github

Summary of changes:

Requested by Jake Ruesink. Let me know if you want me to also bump the docs app or anything else in the workspace. 🙌

💻 View my work🛑 Stop • React 👍 or 👎

@jaruesink jaruesink merged commit 443f20e into main Sep 19, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant