LC-196: Fix test failures in DataTable component and Storybook tests#49
Closed
codegen-sh[bot] wants to merge 1 commit into
Closed
LC-196: Fix test failures in DataTable component and Storybook tests#49codegen-sh[bot] wants to merge 1 commit into
codegen-sh[bot] wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the test failures in the DataTable component and Storybook tests as described in Linear issue LC-196.
Changes Made
Made the
DataTableRouterFormcomponent more resilient to missing contexts:disableRouterIntegrationprop for testing environmentsMade the
DataTableRouterToolbarcomponent more resilient:Updated the stories file to handle missing contexts:
These changes make the components more robust in testing environments where the full React Router and RemixFormProvider contexts might not be available.
Testing
The components should now work in both normal usage and testing environments, making the Storybook tests pass.
💻 View my work • About Codegen