fix: use native LanceDB pagination instead of full table load#18
Merged
gordonmurray merged 1 commit intoMar 16, 2026
Merged
Conversation
Use count_rows() + take_offsets() to read only the requested page from disk, avoiding the full table load. Falls back to Arrow slice() on older Lance versions that lack these methods. Replaces the to_pylist() approach that converted the entire dataset to Python dicts before paginating. Tested: lancedb 0.24.3 (native path), 0.3.4 (fallback path). Untested: 0.16.0, 0.5, 0.3.1 — fallback should handle these. Closes lance-format#13
gordonmurray
force-pushed
the
fix/native-pagination
branch
from
1652e5f to
dc28500
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_pylist()full-table-load pagination with LanceDB's nativecount_rows()+take_offsets(), reading only the requested page from diskslice()on older Lance versions that lack these methodsVersion support
take_offsets()(native)Test plan
?columns=col1,col2Closes #13