feat: configurable port via PORT environment variable#36
Merged
gordonmurray merged 1 commit intoApr 6, 2026
Merged
Conversation
The listening port was hardcoded to 8080. While Docker port mapping
covers most cases, some orchestrators and reverse proxy setups prefer
the container to listen on a specific port.
Changes:
- entrypoint.sh reads PORT env var with default of 8080
- Dockerfile sets ENV PORT=8080 as the default
- Healthcheck uses ${PORT} so it works with custom ports
Backwards compatible: default behavior is unchanged (port 8080).
Tested with default port (8080) and custom port (PORT=9090),
both return 200 on /healthz.
Fixes lance-format#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PORTenv var (defaults to 8080, fully backwards compatible)Changes
Two files changed:
docker/entrypoint.sh,docker/Dockerfileentrypoint.sh: readsPORTenv var with${PORT:-8080}default, passes it to uvicornDockerfile: addsENV PORT=8080as the documented default, healthcheck uses${PORT}so it works with custom portsTest
Both return 200 on
/healthz.Fixes #25