feat(rest)!: require virtual column outputs#346
Merged
Conversation
BREAKING CHANGE: remove AddVirtualColumnEntry.data_type and require outputs.
github-actions
Bot
added
enhancement
jackye1995
approved these changes
Jun 1, 2026
Collaborator
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
Make sure when you release it you bump the minor version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddVirtualColumnEntry.data_typewith requiredAddVirtualColumnEntry.outputsin the canonical OpenAPI spec.AddVirtualColumnOutputEntryfor physical output column, UDF struct field, JSON data type, nullability, and optional metadata.Breaking Change
REST add-virtual-column payloads now require
virtual_column.outputs; the old top-levelvirtual_column.data_typefield is removed from the public contract and generated models.Validation
make lintmake genuv run pytestinpython/lance_namespace_urllib3_client(243 passed)cargo +1.88.0 test --all-featuresinrust/lance-namespace-reqwest-client./mvnw install -pl lance-namespace-apache-client,lance-namespace-async-client,lance-namespace-springboot-server -am -DskipTestsinjavagit diff --check