fix: clean and regenerate summary index on duplicate document upload (#36937)#36964
Open
shifang0511 wants to merge 2 commits into
Open
fix: clean and regenerate summary index on duplicate document upload (#36937)#36964shifang0511 wants to merge 2 commits into
shifang0511 wants to merge 2 commits into
Conversation
shifang0511
requested review from
JohnJyong,
QuantumGhost and
laipz8200
as code owners
dosubot
Bot
added
the
size:M
6 tasks
…anggenius#36937) When a duplicate document is uploaded, _duplicate_document_indexing_task clears old segments and vectors but previously skipped cleaning summary index entries and never re-queued summary generation. This left stale summary data and prevented new summaries from being created. - Delete old summary DB records and vectors alongside segment cleanup - Re-queue summary index generation after duplicate indexing completes, matching the behavior of normal document indexing task Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shifang0511
force-pushed
the
fix/duplicate-document-summary-cleanup-36937
branch
from
80236f5 to
2dfdf42
Compare
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a duplicate document is uploaded,
_duplicate_document_indexing_taskclears old segments and vectors but previously skipped cleaning summary index entries and never re-queued summary generation. This left stale summary data and prevented new summaries from being created after a duplicate upload.Changes:
SummaryIndexService.delete_summaries_for_segmentsCloses #36937
Test plan
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com