fix: preserve annotation reply metadata#37001
Open
minzifang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #37000
This PR preserves
metadata.annotation_replyinmessage_endresponses so the frontend can detect annotation-hit replies correctly.The metadata was previously stripped in two backend paths:
api/core/app/apps/base_app_generate_response_converter.pyapi/core/app/apps/advanced_chat/generate_task_pipeline.pyFor chatflow / advanced chat, annotation replies short-circuit workflow execution, so the frontend relies on
message_end.metadata.annotation_replyto clear the responding state and show annotation metadata. Without this field, the stop-response button can remain visible after an annotation reply.Screenshots
The visual reproduction is documented in the linked issue. The affected UI shows an annotation reply already returned while the stop-response button remains visible.
Tests
pytest -o addopts="" \ tests/unit_tests/core/app/apps/agent_chat/test_agent_chat_generate_response_converter.py \ tests/unit_tests/core/app/apps/completion/test_completion_generate_response_converter.py \ tests/unit_tests/core/app/apps/advanced_chat/test_generate_task_pipeline_core.py -qResult:
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods