Skip to content

Removed logging check that was causing dependency fetching to fail #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanBeard wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed logging check that was causing dependency fetching to fail #3009

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5442f4
Removed logging check on releases that was causing dependency fetchin…
DanBeard Oct 3, 2022
9b4cb0e
Update app/models/package_manager/pypi.rb
DanBeard Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/package_manager/pypi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def self.dependencies(name, version, _mapped_project)
api_response = get("https://pypi.org/pypi/#{name}/#{version}/json")
deps = api_response.dig("info", "requires_dist")
source_info = api_response.dig("releases", version)
Rails.logger.warn("Pypi sdist (no deps): #{name}") unless source_info.any? { |rel| rel["packagetype"] == "bdist_wheel" }
#Rails.logger.warn("Pypi sdist (no deps): #{name}") unless source_info.any? { |rel| rel["packagetype"] == "bdist_wheel" }
Comment thread
DanBeard marked this conversation as resolved.
Outdated

deps.map do |dep|
name, version = dep.split
Expand Down