staticaddr/withdraw: add retry and reorg handling for withdrawals

[kaldun-tech]

Summary

Fixes Issue #1087

Addresses three related issues in the static address withdrawal manager:

1. No retry on registration failure - RegisterSpendNtfn / RegisterConfirmationsNtfn failures silently stopped monitoring
2. No reorg handling - Reorged transactions weren't re-registered
3. State persistence race - handleWithdrawal failure prevented state persistence, breaking recovery

Changes

• Reorder state persistence to happen BEFORE handleWithdrawal so recovery works even if monitoring setup fails
• Add retry-on-next-block for registration failures
• Add reorg detection via lndclient.WithReOrgChan() - on reorg after spend detection, returns to spend watching (not just confirmation re-registration) since the spend tx itself may be invalidated
• Make handleWithdrawal async/best-effort since tx is already published

Testing

go test -v ./staticaddr/withdraw/...

Pull Request Checklist

• Update release_notes.md if your PR contains major features, breaking changes or bugfixes

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability of the static address withdrawal manager by addressing critical gaps in error handling and state management. By introducing robust retry mechanisms for notification registration, implementing reorg detection, and ensuring state is persisted before monitoring begins, the system is now more resilient to transient chain issues and process restarts.

Highlights

• Robust Withdrawal Monitoring: Implemented automatic retry logic for registration failures, ensuring that monitoring does not silently stop if notification registration fails.
• Reorg Handling: Integrated reorg detection using lndclient's WithReOrgChan, allowing the manager to correctly re-register for spend notifications if a transaction is invalidated by a reorg.
• State Persistence Ordering: Reordered state persistence to occur before monitoring setup, ensuring that recovery processes can correctly identify and resume pending withdrawals after a restart.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the reliability of static address withdrawals by implementing automatic retries for notification registrations and robust handling for blockchain reorgs. It also reorders state persistence to ensure that withdrawals can be recovered correctly after a restart. The review feedback identifies several opportunities to harden the implementation, specifically by handling potential channel closures to prevent panics or tight loops during shutdown, and ensuring that the correct transaction hash is cleared from the internal tracking map when Replace-By-Fee (RBF) transactions are confirmed.

[lightninglabs-deploy]

@kaldun-tech, remember to re-request review from reviewers when ready

[kaldun-tech]

@hieblmi Ready for review