Conversation
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-math
branch
from
c832763 to
24fe535
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-math
branch
2 times, most recently
from
2212660 to
90bacf6
Compare
3 tasks
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-math
branch
4 times, most recently
from
23029a9 to
813ee32
Compare
Buristan
approved these changes
May 26, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the patch!
Generally LGTM, with a bunch of nits below.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-math
branch
3 times, most recently
from
26aba7c to
deb7be6
Compare
Buristan
approved these changes
May 31, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the fixes!
LGTM, with two comments below.
The patch adds a tests for Lua math standard unctions. Also, the patch introduces a helper `lua_current_version_ge_than()` for convenient versions comparisons and a helper `approx_equal()` for convenient numbers comparisons. Rules from trigonometric identities [1] has been used as invariants for trigonometric functions. 1. https://en.wikipedia.org/wiki/List_of_trigonometric_identities
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-math
branch
from
deb7be6 to
add009c
Compare
ligurio
added a commit
to ligurio/lunapark-corpus
that referenced
this pull request
Jun 3, 2025
The commit "tests/lapi: add math tests" [1]. 1. ligurio/lunapark@2974b65 Follows up ligurio/lunapark#123 Related to tarantool/tarantool#11401 Related to tarantool/tarantool#11301
ligurio
added a commit
to ligurio/lunapark-corpus
that referenced
this pull request
Jun 3, 2025
The commit "tests/lapi: add math tests" [1]. 1. ligurio/lunapark@2974b65 Follows up ligurio/lunapark#123 Related to tarantool/tarantool#11401 Related to tarantool/tarantool#11301
ligurio
added a commit
to ligurio/lunapark-corpus
that referenced
this pull request
Apr 1, 2026
The commit "tests/lapi: add math tests" [1]. 1. ligurio/lunapark@2974b65 Follows up ligurio/lunapark#123 Related to tarantool/tarantool#11401 Related to tarantool/tarantool#11301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #121.