Conversation
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-package
branch
3 times, most recently
from
0ed293c to
1fdabf7
Compare
7 tasks
Buristan
requested changes
Jul 17, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the patch!
Please consider my comments below.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-package
branch
2 times, most recently
from
37550d0 to
bea61d5
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-package
branch
from
bea61d5 to
df93991
Compare
Buristan
approved these changes
Jul 24, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the fixes!
LGTM, after fixing the last discussion above.
The patch adds a test for the `require()` function. Note, the test is disabled by default.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-package
branch
from
df93991 to
a6451b5
Compare
Buristan
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.