Support bitwise operations in luaL_loadbuffer_proto#137
Merged
Conversation
ligurio
force-pushed
the
ligurio/gh-xxxx-support-bitwise-operations
branch
4 times, most recently
from
e1d1dde to
85d173c
Compare
Buristan
approved these changes
Jul 17, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the patch-set!
I'll proceed with the review per-patch below.
[PATCH 1/3] extra: add more errors found in PUC Rio Lua
LGTM.
Buristan
requested changes
Jul 17, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
[PATCH 2/3] tests/capi: support floor division operation
Thanks for the patch!
Please consider my comment below.
Buristan
requested changes
Jul 17, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
[PATCH 3/3] tests/capi: support bitwise operations in luaL_loadbuffer_proto
Thanks for the patch!
Please consider my comment below.
ligurio
force-pushed
the
ligurio/gh-xxxx-support-bitwise-operations
branch
from
85d173c to
c410a55
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-support-bitwise-operations
branch
from
c410a55 to
e0dab88
Compare
Buristan
approved these changes
Jul 29, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the fixes!
LGTM, after fixing 2 nits below.
The PUC Rio Lua 5.3 has introduced a floor division (//) operation. It is a division that rounds the quotient towards minus infinity, that is, the floor of the division of its operands. The patch adds support of the aforementioned operation to a protobuf schema, serializer and preamble.
The `bit32` library has been deprecated in PUC Rio Lua 5.3 [1]. Missed bitwise functions have been replaced by appropriate bitwise operations [2]. The patch adds support of bitwise operations to the test `luaL_loadbuffer_proto`. 1. https://www.lua.org/manual/5.3/manual.html#8.2 2. https://www.lua.org/manual/5.3/manual.html#3.4.2
ligurio
force-pushed
the
ligurio/gh-xxxx-support-bitwise-operations
branch
from
e0dab88 to
82f87c0
Compare
Collaborator
|
Sergey, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.