Conversation
7 tasks
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-table
branch
4 times, most recently
from
4b7cde9 to
be50402
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-table
branch
3 times, most recently
from
2791879 to
259b7c2
Compare
Buristan
requested changes
Jul 16, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the patch!
Please consider my comments below.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-table
branch
4 times, most recently
from
babbc83 to
98a0fe3
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-table
branch
3 times, most recently
from
244864b to
9ecb921
Compare
Buristan
requested changes
Jul 25, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the fixes!
Please consider bunch of nits below.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-table
branch
from
9ecb921 to
88d4268
Compare
The patch adds a fuzzing tests for Lua table functions except the the function `table.unpack`, it will be tested by `builtin_unpack_test.lua`.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-table
branch
from
88d4268 to
cd6f54b
Compare
Buristan
approved these changes
Jul 25, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Sergey,
Thanks for the fixes!
LGTM!
ligurio
added a commit
to ligurio/lunapark-corpus
that referenced
this pull request
Jul 28, 2025
Follows up ligurio/lunapark#142 Related to tarantool/tarantool#11470
ligurio
added a commit
to ligurio/lunapark-corpus
that referenced
this pull request
Jul 28, 2025
Follows up ligurio/lunapark#142 Related to tarantool/tarantool#11470
ligurio
added a commit
to ligurio/lunapark-corpus
that referenced
this pull request
Sep 11, 2025
Follows up ligurio/lunapark#142 Related to tarantool/tarantool#11470
ligurio
added a commit
to ligurio/lunapark-corpus
that referenced
this pull request
Apr 1, 2026
Follows up ligurio/lunapark#142 Related to tarantool/tarantool#11470
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.