luzer: initialize FDP metatable only once#28
Merged
ligurio merged 1 commit intoligurio:masterfrom Mar 26, 2025
Merged
Conversation
The FDP metatable is recreating each time when we initialize the FDP object. It increases the GC consumption and makes the code less JIT-friendly since traces are exited by the guard on the FDP methods objects that checked the exact pointer of the `GCobj` which is new for any new FDP provider. This patch fixes that by initializing the metatable only once on the luzer library loading.
ligurio
force-pushed
the
skaplun/init-fdp-metatable-once
branch
from
3914471 to
bc137f1
Compare
Owner
|
Fixed codestyle: --- a/luzer/fuzzed_data_provider.cc
+++ b/luzer/fuzzed_data_provider.cc
@@ -266,7 +266,8 @@ const luaL_Reg methods[] =
* friendly. `luaL_fuzzed_data_provider()` is called in the loop inside
* `LLVMFuzzerRunDriver()`.
*/
-void fdp_metatable_init(lua_State *L)
+void
+fdp_metatable_init(lua_State *L)
{
luaL_newmetatable(L, FDP_LUA_UDATA_NAME);
lua_pushvalue(L, -1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FDP metatable is recreating each time when we initialize the FDP object. It increases the GC consumption and makes the code less JIT-friendly since traces are exited by the guard on the FDP methods objects that checked the exact pointer of the
GCobjwhich is new for any new FDP provider.This patch fixes that by initializing the metatable only once on the luzer library loading.