Fix installation and build using luarocks#33
Merged
Conversation
luarocks documentation has been moved from Github's wiki [1] to repository [2]. The patch fixes a link to description of rockspec file format. 1. https://github.com/luarocks/luarocks/wiki/ 2. https://github.com/luarocks/luarocks/blob/main/docs/index.md
The patch sets all libraries for custom_mutator library in a one go.
SweetVishnya
approved these changes
Apr 5, 2025
Buristan
reviewed
Apr 7, 2025
ligurio
force-pushed
the
ligurio/gh-27-fix-luarocks
branch
from
85628e1 to
5a5ee81
Compare
ligurio
force-pushed
the
ligurio/gh-27-fix-luarocks
branch
2 times, most recently
from
1fa08b4 to
701b439
Compare
Github Actions breaks `check` workflow due to scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-15, see [1]. The patch bumps an Ubuntu version in workflows. 1. actions/runner-images#11101
The patch fixes regular expression that replaces branch and version in rockspec before publishing. Regular expression uses single quotes, but rockspec uses double quotes and this leads to broken version and branch update. Follows up commit 866620f ("ci: update publishing steps").
ligurio
force-pushed
the
ligurio/gh-27-fix-luarocks
branch
2 times, most recently
from
df0f226 to
1af7491
Compare
The patch fixes a broken build testing steps. The commit e52d181 ("Initial version") introduced a versioning for `libcustom_mutator` shared library, but seems it is not actually needed and `SOVERSION` has been removed. The patch also added a test that installs the module using luarocks, set environment variables using luarocks and checks that module was successfully found by Lua interpreter. Fixes #4
ligurio
force-pushed
the
ligurio/gh-27-fix-luarocks
branch
from
1af7491 to
d75833f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
Fixes #4