docs: sync README triton floor with setup.py and fix contributing install command#1301
Open
kobihikri wants to merge 1 commit into
Open
docs: sync README triton floor with setup.py and fix contributing install command#1301kobihikri wants to merge 1 commit into
kobihikri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small documentation accuracy fixes:
triton >= 2.3.0, butsetup.pyresolvestriton>=2.3.1— issue I have triton 3.3.0 but it shows this error : liger-kernel 0.5.8 depends on triton>=2.3.1 #682 shows a user hitting exactly this confusion. Updated the README to>= 2.3.1so both sources agree.pip install . -e[dev], which isn't valid pip syntax (the guide even carries a workaround note for the error it causes). Replaced withpip install -e ".[dev]", matching AGENTS.md and the README.Testing Done
Doc-only change. Verified
setup.pyline 17 (triton>=2.3.1) and thatpip install -e ".[dev]"is the form AGENTS.md uses.make testto ensure correctness — n/a, docs onlymake checkstyleto ensure code style — n/a, docs onlymake test-convergenceto ensure convergence — n/a, docs onlyFor transparency (per AGENTS.md's AI-assistant support): I used AI assistance to spot and draft this; I verified both lines against setup.py and issue #682 myself.