Track Simplification Origins by Full VC Implication#262
Merged
Conversation
rcosta358
force-pushed
the
new-origins-approach
branch
from
0ecbb8f to
f5cccb1
Compare
CatarinaGamboa
approved these changes
Jun 21, 2026
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
Collaborator
There was a problem hiding this comment.
this is easier to explain than the previous ideas
| this.refinement = ref; | ||
| } | ||
|
|
||
| public VCImplication getOrigin() { |
| /** | ||
| * Result of simplifying VC implication chain | ||
| */ | ||
| public final class VCSimplificationResult { |
Collaborator
There was a problem hiding this comment.
Couldnt this extend VCSimplification but just with a new field for origin? Then we could use them interchangeably. This also works and maybe is less confusing but it would be nice to use the result without doing .getImplication
Collaborator
Author
There was a problem hiding this comment.
Yeah, it's definitely less confusing this way, but I can explore that idea in the future.
rcosta358
force-pushed
the
new-origins-approach
branch
from
6072503 to
6512612
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors VC simplification origin tracking. Instead of storing origins on individual
VCImplicationnodes, each simplification step now records the complete VC implication chain through a newVCSimplificationResult.Example
Related Issue
None.
Type of change
Checklist
mvn testpasses locally