feat(ci-test-notify): add info status for informational notices#160
Open
Piotr1215 wants to merge 1 commit into
Open
feat(ci-test-notify): add info status for informational notices#160Piotr1215 wants to merge 1 commit into
Piotr1215 wants to merge 1 commit into
Conversation
Callers that want a standalone Slack ping (a deploy landed, an RC reached staging) had no fitting status: success and failure force a pass/fail header with a "Success"/"Failed" suffix that misreads an informational notice, and the fallback case renders "Unknown". Add an `info` status that always notifies (still suppressed on an empty webhook, same as before) and renders a rocket header with no status suffix. This lets hosted-platform's staging RC notification reuse this action instead of hand-rolling a jq+curl Slack POST that duplicates the gate, payload, and send logic already living here (DEVOPS-577).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
infostatus to theci-test-notifyaction for standalone informational Slack pings (a deploy landed, a release candidate reached staging), wheresuccess/failurewould force a misleading pass/fail header and suffix.What
build-payload.sh: newinfocase, rocket emoji, no status suffix. Header assembly omits the trailing suffix only when empty, so existingsuccess/failure/cancelled/skippedheaders are byte-for-byte unchanged.should-notify.sh:infoalways notifies (still suppressed on an empty webhook, e.g. fork PRs). Gating forcancelled/skippedis untouched.action.yml+README.md: document the status; regenerated the auto-doc input table.infocoverage tobuild-payload.batsandshould-notify.bats.Why
hosted-platformPR #530 hand-rolls ajq+curlSlack POST to tell QA an RC deployed to staging. That duplicates the gate/payload/send logic already in this action. This is the smallest additive change that lets that workflow reuseci-test-notifyinstead. See the reuse-first convention.Tests
make test-ci-test-notify— 33/33 pass (2 new).shellcheckclean on both scripts.make generate-docsrun; no drift outside this action.References DEVOPS-577.