Skip to content

feat(discord): status based notification suppress switches - #7634

Open
Maxme-L wants to merge 10 commits into
louislam:masterfrom
Maxme-L:discord-ping-switches
Open

feat(discord): status based notification suppress switches#7634
Maxme-L wants to merge 10 commits into
louislam:masterfrom
Maxme-L:discord-ping-switches

Conversation

@Maxme-L

@Maxme-L Maxme-L commented Jul 27, 2026

Copy link
Copy Markdown

Summary

In this pull request, the following changes are made:

  • Replace the single discordSuppressNotifications switch with suppress switches depending on the status of the notification

The added switches allow one user to suppress notifications, thus, the selected status notifications won't generate any ping on push notifications.

Minor Breaking Change: the previous switch is completely replaced by the two new ones, disabled by default. Users who had toggled the suppress switch will have to do it again.

Resolves #7619

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

Before After
image Screenshot from 2026-07-26 18-12-30

Screenshots for Behavior test

Message format Settings Discord
Normal (rich embeds) image image
Minimalist image image
Custom template image image

This is my first contribution to an open source project. I'm open to any feedback to make this better.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR! If anyone would like to help with testing, run: npx kuma-pr Maxme-L:discord-ping-switches (requires Node.js and Docker)

@github-actions

Copy link
Copy Markdown
Contributor

Hello and thanks for lending a paw to Uptime Kuma! 🐻👋
As this is your first contribution, please be sure to check out our Pull Request guidelines.
In particular: - Mark your PR as Draft while you’re still making changes - Mark it as Ready for review once it’s fully ready
If you have any design or process questions, feel free to ask them right here in this pull request - unclear documentation is a bug too.

@Maxme-L
Maxme-L marked this pull request as draft July 28, 2026 10:35
@Maxme-L
Maxme-L marked this pull request as ready for review July 28, 2026 10:35
@github-actions github-actions Bot added the pr:needs review this PR needs a review by maintainers or other community members label Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:needs review this PR needs a review by maintainers or other community members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Discord notifications to be silenced depending on the status (UP/DOWN)

1 participant