fix(mqtt): propagate JSON query evaluation errors - #7643
Open
larsch wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the PR! If anyone would like to help with testing, run: |
Contributor
|
Hello and thanks for lending a paw to Uptime Kuma! 🐻👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagate MQTT JSONata evaluation errors instead of silently discarding them.
Report errors using the same format as HTTP(S) JSON-query monitors:
Prevent invalid expressions such as
$toMillis("junk")from producing an empty value that numeric conditions interpret as0.Add a focused regression test covering an invalid
$toMillis()expression with an MQTTjson_valuecondition.Preserve the existing HTTP(S) regression test confirming that invalid
$toMillis()input is propagated.Resolves MQTT JSON query conditions treat expression errors as zero #7642.
Full disclosure; AI was used to troubleshoot, debug, and implement this test and change, but I have reviewed and to my ability, the change and test are sound. The change is a one-liner, which brings the behavior into consistency with HTTP(s) endpoints. The focused unit test pass, and I have tested on a live install and verified the effectiveness of the fix.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.