Update release notes and changelog#362
Draft
alerque wants to merge 3 commits into
Draft
Conversation
Tieske
reviewed
Oct 9, 2020
Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
Member
|
@alerque this is still a draft, I'm looking to push a new release. Do you want to update this and have it in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm posting this as a draft for now because I'm second guessing whether this is the correct procedure for releasing rockspecs. Perhaps @hishamhm you can chime in here. Removing the
rockspec_format = "3.0"seems necessary to keep old Luarocks users happy, but it also leaves users of modern Luarocks with less features. That doesn't seem right.This release process is required to lint properly, but maybe the keys would just be ignored in old versions so we can just reduce the format version and ignore the lint error to feed new keys to everybody? Whats the best procedure here? (see 070c8e1, 92173be, and 65982bb for context)