Skip to content

Pwa 3615 - #4574

Merged
glo82145 merged 2 commits into
developfrom
PWA-3615
Nov 17, 2025
Merged

Pwa 3615#4574
glo82145 merged 2 commits into
developfrom
PWA-3615

Conversation

@del15881

@del15881 del15881 commented Nov 6, 2025

Copy link
Copy Markdown
Collaborator

Description

Fixing the issue with Homepage Grid Layout.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3615

Closes #PWA-3615.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del15881
del15881 requested a review from glo82145 November 6, 2025 06:42
@del15881 del15881 added the version: Patch This changeset includes backwards compatible bug fixes. label Nov 6, 2025
@pwa-studio-bot

Copy link
Copy Markdown
Collaborator
Fails
馃毇

node failed.

Log

Details
Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-7e611561.json

Generated by 馃毇 dangerJS against 396282b

@pwa-studio-bot

Copy link
Copy Markdown
Collaborator
Fails
馃毇

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 馃毇 dangerJS against 396282b

@pwa-studio-bot

Copy link
Copy Markdown
Collaborator
Fails
馃毇

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 馃毇 dangerJS against 396282b

@pwa-studio-bot

Copy link
Copy Markdown
Collaborator
Fails
馃毇

node failed.

馃毇

GraphQL queries did not pass. Make sure to execute yarn run validate-queries locally prior to committing.

馃毇 Missing information in PR. Please fill out the "Description" section.
Warnings
鈿狅笍 Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
馃摉

Associated JIRA tickets: PWA-3615.

馃摉 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
馃摉

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: validateQueries


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 馃毇 dangerJS against 396282b

@glo82145
glo82145 merged commit 9b9352e into develop Nov 17, 2025
2 of 14 checks passed
@del22123
del22123 deleted the PWA-3615 branch February 17, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants