Skip to content

PWA-3664 : Config option selection fix - #4606

Open
del22123 wants to merge 4 commits into
developfrom
PWA-3664
Open

PWA-3664 : Config option selection fix#4606
del22123 wants to merge 4 commits into
developfrom
PWA-3664

Conversation

@del22123

Copy link
Copy Markdown
Collaborator

Description

Fixes the configurable option dynamic disabling on option selection bug

Related Issue

https://jira.corp.adobe.com/browse/PWA-3664

Closes #PWA-3661.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del22123
del22123 requested review from del15881 and glo82145 April 15, 2026 17:24
@del22123 del22123 self-assigned this Apr 15, 2026
@del22123 del22123 added the version: Patch This changeset includes backwards compatible bug fixes. label Apr 15, 2026
@pwa-studio-bot

pwa-studio-bot commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator
Fails
馃毇

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 馃毇 dangerJS against 7d13d27

del15881
del15881 previously approved these changes Apr 15, 2026
@pwa-studio-bot

pwa-studio-bot commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator
Fails
馃毇

node failed.

馃毇

Unit tests in the following files did not pass 馃様. All tests must pass before this PR can be merged

  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/orderRow.spec.js
Messages
馃摉

Associated JIRA tickets: PWA-3664.

馃摉 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
馃摉

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 馃毇 dangerJS against 7d13d27

@pwa-studio-bot

pwa-studio-bot commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator
Fails
馃毇

node failed.

馃毇

Cypress tests in the following files did not pass 馃様. All tests must pass before this PR can be merged

  • displays assigned products:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,shows products specific to the categories in the different store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"]`, but never found it.
    ,lets users add products to cart regardless of store view:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="CategoryContent-root"] [data-cy="GalleryItem-root"]`, but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 馃毇 dangerJS against 7d13d27

glo82145
glo82145 previously approved these changes Apr 16, 2026
@pwa-studio-bot

pwa-studio-bot commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator
Fails
馃毇 Lighthouse assertions failed 馃様. All assertions must pass before this PR can be merged
https://pr-4606.pwa-venia.com/valeria-two-layer-tank.html

First Contentful Paint (maxNumericValue)

  • Expected: 3200
  • Actual: 3209.2035
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/first-contentful-paint/
馃毇

node failed.

Log

Details

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-cbdba923.json

Generated by 馃毇 dangerJS against 7d13d27

@glo82145

Copy link
Copy Markdown
Collaborator

run pr-test

@pwa-test-bot

pwa-test-bot Bot commented Apr 16, 2026

Copy link
Copy Markdown

Successfully started codebuild job for pr-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:peregrine pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants