Skip to content

various: fix newline spam on load#19

Draft
plumj-am wants to merge 1 commit into
manic-systems:mainfrom
plumj-am:patch/PlumJam-zvnsyvnoovvu
Draft

various: fix newline spam on load#19
plumj-am wants to merge 1 commit into
manic-systems:mainfrom
plumj-am:patch/PlumJam-zvnsyvnoovvu

Conversation

@plumj-am

@plumj-am plumj-am commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

It doesn't happen every time and I wasn't able to figure out exactly why it did. However, it is fixed by this change. Now the status updates re-use the same line which I assume is the intention.

Before (shortened but it was about twice this length):

p[\] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[-] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[/] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[|] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[\] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[-] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[/] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[|] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[\] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[-] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[/] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; 
p[|] cade: nix develop at /home/jam/projects/grove-3 is taking a long time; press Ctrl-C to stop and inspect the command.

After:

cade is now allowed in /home/jam/projects/grove-3.
[→] cade: loaded /home/jam/projects/grove-3.
grove root loaded!

Signed-off-by: PlumJam <git@plumj.am>
@plumj-am plumj-am marked this pull request as draft June 4, 2026 17:48
@plumj-am

plumj-am commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

It still appears to be an issue, though maybe less frequent? Can't be sure. I'll keep digging.

@atagen

atagen commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

should be fixed on next branch, it's caused by poor line accounting when the terminal is small enough for the line to wrap

@plumj-am

plumj-am commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

I don't think the terminal size is the only issue. I occasionally encountered it on large (>120 column) terminals too where the width was plenty for cade. Perhaps that issue is fixed by my change because it hasn't happened since. It's difficult when these things happen so intermittently... Anyway, I'm sure can get to the bottom of it :)

@plumj-am

plumj-am commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Yes, even using my patched version, I still get this. 190 columns so shouldn't be width constrained @atagen:

screenshot_2026-06-05_13-30-54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants