queue-runner: match venue capabilities against the will-build closure#92
Open
amaanq wants to merge 2 commits into
Open
queue-runner: match venue capabilities against the will-build closure#92amaanq wants to merge 2 commits into
amaanq wants to merge 2 commits into
Conversation
nix-eval-jobs only emits `inputDrvs` behind this flag, so `input_drvs` was always `None` and no eval ever produced a dependency edge.
`required_features` only covers the job's own drv, but the venue realises the whole unbuilt closure. Dispatch now dry-runs the drv and schedules on the `requiredSystemFeatures` union of the will-build set. A build with no capable venue stays pending instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required_featuresonly covers the job's own drv, but the venue realisesthe whole unbuilt closure.
Dispatch now dry-runs the drv and schedules on the
requiredSystemFeaturesunion of the will-build set. A build with no capable venue stays pending
instead of crashing.
(Also a small commit beforehand passes
--show-input-drvsto nix-eval-jobs, see commit msg for why)