Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4de4303989
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "tsconfig-paths-webpack-plugin": "^4.2.0", | ||
| "tsx": "^4.22.4", | ||
| "typescript": "6.0.3", | ||
| "typescript": "7.0.2", |
There was a problem hiding this comment.
npm run docs:docgen (package.json lines 32/35) runs scripts/docgen/index.ts, which calls mantine-docgen-script; the lockfile shows that path uses react-docgen-typescript, whose peer is named typescript. TypeScript 7.0 does not ship the compiler API, so resolving that peer to this new typescript 7.0.2 package makes docs generation and docs builds fail even though typescript-api is installed, because those dependencies still import the peer as typescript. Keep the API-compatible TypeScript 6 package at the typescript name for API consumers, or wire the docgen dependency to the alias.
Useful? React with 👍 / 👎.
| "rehype-slug": "^6.0.0", | ||
| "shiki": "^4.2.0", | ||
| "typescript": "6.0.3" | ||
| "typescript": "7.0.2" |
There was a problem hiding this comment.
The docs apps already set typescript.ignoreBuildErrors, but Next 16 still probes the installed typescript package during build setup and current TS7 support discussion shows it looks for the legacy JS API entrypoint (typescript/lib/typescript.js), which TypeScript 7 does not ship. With typescript@7.0.2 installed under the canonical name here (and in apps/help.mantine.dev), next build can fail in CI for npm run docs:build/npm run hc:build even though the separate tsc --noEmit step is the one meant to use TS7; keep a TS6-compatible package at typescript for Next or move TS7 to a separate alias/CLI backend.
Useful? React with 👍 / 👎.
1 participant
No description provided.