[@mantine/core] Drawer/Modal: Add Footer components#9077
Open
saadpocalypse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users currently struggle to implement fixed footer content (such as action buttons) at the bottom of a
DrawerorModalwhen the main body content (Drawer.Body/Modal.Body) is scrollable.Common workarounds (like reusing
<Drawer.Header bottom={0}>Footer</Drawer.Header>or using custom absolutely positioned containers) are hacky, break HTML semantics (using a<header>tag for a footer), and require manual layout overrides that conflict with style rules. There was no native support for a sticky footer layout.Solution
ModalBaseFooterinpackages/@mantine/core/src/components/ModalBaserendering a semantic<footer>element..footerCSS class toModalBase.module.csswith sticky positioning (position: sticky; bottom: 0;), background color support, and standard padding spacing.Drawer.Footercomponent usingModalBaseFooterwith support for Drawer styles API.Modal.Footercomponent usingModalBaseFooterwith bottom corner border-radius variables (border-end-start-radius/border-end-end-radius) configured inModal.module.css.footerselector inside theDrawerandModalstyles API definitions.WithFooterstory test cases in bothDrawer.story.tsxandModal.story.tsxfor easy manual verification.Tests
npm run jest packages/@mantine/core/src/components/Drawer/Drawer.test.tsx packages/@mantine/core/src/components/Modal/Modal.test.tsx— 556 tests passed successfully.npm run typecheck,npm run build,npm run oxlint, andnpm run stylelint.Resolves #4540 and #8680