Fix dataframe filter_rows list payload parsing#9770
Draft
nkgotcode wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
What changed
This fixes #7433 by accepting the legacy/list-shaped
filter_rows.wherepayload emitted by dataframe form row filters and normalizing it into aFilterGroup. Grouped-object payloads continue to be accepted unchanged.The change also adds focused parser and dataframe form coverage for the list-shaped row-filter payload.
Tests
uv run --group test pytest tests/_plugins/ui/_impl/dataframes/test_transforms.py::test_parse_filter_rows_transform_with_legacy_list_where tests/_plugins/ui/_impl/dataframes/test_transforms.py::test_parse_transforms -quv run --group test --group test-optional pytest tests/_plugins/ui/_impl/dataframes/test_dataframe.py::TestDataframes::test_dataframe_form_accepts_filter_rows_list_where -quv run --group test pytest tests/_plugins/ui/_impl/dataframes/test_transforms.py -qChecklist