Skip to content

fix: code 0 is reserved but unknowCoder define 1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
newnature1992 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: code 0 is reserved but unknowCoder define 1 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
)

var (
unknownCoder defaultCoder = defaultCoder{1, http.StatusInternalServerError, "An internal server error occurred", "http://github.com/marmotedu/errors/README.md"}
unknownCoder defaultCoder = defaultCoder{0, http.StatusInternalServerError, "An internal server error occurred", "http://github.com/marmotedu/errors/README.md"}
)

// Coder defines an interface for an error code detail information.
Expand Down Expand Up @@ -71,7 +71,7 @@ var codes = map[int]Coder{}
var codeMux = &sync.Mutex{}

// Register register a user define error code.
// It will overrid the exist code.
// It will override the exist code.
func Register(coder Coder) {
if coder.Code() == 0 {
panic("code `0` is reserved by `github.com/marmotedu/errors` as unknownCode error code")
Expand Down