Skip to content

Synthesize PR html_url so dedup drops duplicate lines #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masutaka merged 1 commit into from
Apr 29, 2026
+18 −6
Merged

Synthesize PR html_url so dedup drops duplicate lines #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions lib/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,16 +138,16 @@ func htmlURL(event *github.Event) (string, error) {
result = *e.Issue.HTMLURL
}
case "PullRequestEvent":
if e := payload.(*github.PullRequestEvent); e.PullRequest != nil && e.PullRequest.HTMLURL != nil {
result = *e.PullRequest.HTMLURL
if e := payload.(*github.PullRequestEvent); e.PullRequest != nil && e.PullRequest.Number != nil {
result = pullRequestHTMLURL(event, *e.PullRequest.Number)
}
case "PullRequestReviewCommentEvent":
if e := payload.(*github.PullRequestReviewCommentEvent); e.PullRequest != nil && e.PullRequest.HTMLURL != nil {
result = *e.PullRequest.HTMLURL
if e := payload.(*github.PullRequestReviewCommentEvent); e.PullRequest != nil && e.PullRequest.Number != nil {
result = pullRequestHTMLURL(event, *e.PullRequest.Number)
}
case "PullRequestReviewEvent":
if e := payload.(*github.PullRequestReviewEvent); e.PullRequest != nil && e.PullRequest.HTMLURL != nil {
result = *e.PullRequest.HTMLURL
if e := payload.(*github.PullRequestReviewEvent); e.PullRequest != nil && e.PullRequest.Number != nil {
result = pullRequestHTMLURL(event, *e.PullRequest.Number)
}
case "DiscussionEvent":
if e := payload.(*github.DiscussionEvent); e.Discussion != nil && e.Discussion.HTMLURL != nil {
Expand All @@ -157,3 +157,15 @@ func htmlURL(event *github.Event) (string, error) {

return result, nil
}

// pullRequestHTMLURL constructs a PR's HTML URL from the event's repo and the
// PR number. The /users/{user}/events API returns pull_request payloads
// without an html_url, so we synthesize one to keep dedup keys consistent
// with what IssueCommentEvent.Issue.HTMLURL returns for PR comments.
func pullRequestHTMLURL(event *github.Event, number int) string {
if event.Repo == nil || event.Repo.Name == nil {
return ""
}

return fmt.Sprintf("https://github.com/%s/pull/%d", *event.Repo.Name, number)
}
Loading