fix(desktop): resolve http/https union type errors in electron main#564
Open
ncw1992120 wants to merge 1 commit into
Open
fix(desktop): resolve http/https union type errors in electron main#564ncw1992120 wants to merge 1 commit into
ncw1992120 wants to merge 1 commit into
Conversation
`const client = isHttps ? https : http` produces a `typeof https | typeof http` union, which TypeScript refuses to call .get() on (TS2349), cascading into implicit-any errors on the response/error callbacks (TS7006). Cast to `typeof http` at the call site — https exposes the same callable surface, so the runtime behavior is unchanged. Resolves 5 vue-tsc errors in electron/main/index.ts (lines 303, 433, 440).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #563 — 5
vue-tsctype errors inmateclaw-desktop/electron/main/index.tsthat blocknpm run build.Root cause
The backend health-check helper infers a union type:
TypeScript won't call
.get()on the union (overloads differ), cascading into implicit-any on theres/errcallbacks.Fix
Cast
clienttotypeof httpat the call site —httpsexposes the same callable surface, so runtime is unchanged. Applied to both health-check occurrences (lines ~303 and ~436).Verification
Before: 5 errors. After: 0 errors.
Based on
dev(e294b325), no other files touched.