Improved CI#2079
Open
bfoley12 wants to merge 10 commits into
Open
Conversation
Alab (Experiment) schema modification
…acks gracefully. Relies on justfiles and declaration within ci.yml
bfoley12
commented
Jun 22, 2026
Comment on lines
+40
to
+57
| run: | | ||
| # Map of migrated package -> optional python-version override | ||
| # ("" = use the package's .python-version pin). Only packages whose | ||
| # filter reported a change are emitted into the matrix. | ||
| python3 - "$CHANGES" <<'PY' >> "$GITHUB_OUTPUT" | ||
| import json, sys | ||
| changes = json.loads(sys.argv[1]) | ||
| config = { | ||
| "mpcontribs-api": {"python-version": ""}, | ||
| # "mpcontribs-client": {"python-version": ""}, # add when migrated | ||
| } | ||
| include = [ | ||
| {"package": pkg, **cfg} | ||
| for pkg, cfg in config.items() | ||
| if changes.get(pkg) == "true" | ||
| ] | ||
| print("packages=" + json.dumps(include)) | ||
| PY |
Collaborator
Author
There was a problem hiding this comment.
Provides packages on a "new" stack (uv, justfile) alongside a potential python version override to further CI steps
bfoley12
commented
Jun 22, 2026
Comment on lines
+58
to
+70
|
|
||
| ci: | ||
| needs: discover | ||
| if: ${{ needs.discover.outputs.packages != '[]' }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: ${{ fromJson(needs.discover.outputs.packages) }} | ||
| uses: ./.github/workflows/_python_ci.yml | ||
| with: | ||
| package: ${{ matrix.package }} | ||
| python-version: ${{ matrix.python-version }} | ||
| coverage-artifact: coverage-${{ matrix.package }} |
Collaborator
Author
There was a problem hiding this comment.
Runs a unified CI workflow for each discovered repo. Provides which package is being ran, which version of python to use (defaults to the repos specified version), and where to put the test coverage artifact
bfoley12
commented
Jun 22, 2026
Comment on lines
+73
to
+88
| gate: | ||
| name: ci-success | ||
| if: always() | ||
| needs: [discover, ci] | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Verify CI result | ||
| run: | | ||
| result="${{ needs.ci.result }}" | ||
| # 'skipped' is success here: it means no migrated package needed checking. | ||
| if [ "$result" = "success" ] || [ "$result" = "skipped" ]; then | ||
| echo "CI gate passed (ci job: $result)" | ||
| exit 0 | ||
| fi | ||
| echo "CI gate failed (ci job: $result)" | ||
| exit 1 |
Collaborator
Author
There was a problem hiding this comment.
What actually gets depended on by the repo rules. Should require a status check where context = "ci-success"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Summary
Updated CI to include mpcontribs-api and allow different tech stacks/versions across the sub-repos.
File Changes