Fix a logic bug in Browser::create_browser_context.#315
Open
chanxuehong wants to merge 1 commit intomattsse:mainfrom
Open
Fix a logic bug in Browser::create_browser_context.#315chanxuehong wants to merge 1 commit intomattsse:mainfrom
chanxuehong wants to merge 1 commit intomattsse:mainfrom
Conversation
Browser::start_incognito_context creates a new BrowserContext and sends a HandlerMessage::InsertContext message, whereas Browser::create_browser_context does not perform this step. This commit fixes the inconsistency and also improves the code structure.
3 tasks
Author
|
#309 implements the same functionality as this PR. Either one can be merged as needed, depending on which is more appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
#316
Description of changes
Browser::start_incognito_context creates a new BrowserContext and sends a HandlerMessage::InsertContext message, whereas Browser::create_browser_context does not perform this step.
This commit fixes the inconsistency and also improves the code structure.
Checklist