Add CJK and Eastern-Slavic name romanization round-trip coverage - #2239
Merged
maziyarpanahi merged 5 commits intoAug 12, 2026
Merged
Conversation
…ure-om-cjk-slavic-romanization-roundtrip-sui
Owner
Author
|
Thank you @maziyarpanahi. I reviewed this against #468 and current What changed:
Validation:
This now satisfies the issue and is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dependency-free
romanize_namehelper for deterministic Latin renderings of non-Latin PERSON surrogates. It reuses the existing Unicode script detection and segmentation utilities, with algorithmic Kana, Hangul, Cyrillic, and Greek handling plus deterministic Han-name readings and an explicit ASCII fallback for unknown Han characters.Adds synthetic offline regression coverage for Japanese, Chinese, Korean, Russian, and Greek language packs. The tests exercise detect → replace → re-detect stability, romanized PERSON re-detection, and exact offsets on mixed Latin/non-Latin lines. Unwired language packs skip with a clear wiring reason.
Validation
.venv/bin/python -m pytest tests/unit/core/test_name_romanization_roundtrip.py -q— 15 passed.venv/bin/ruff check openmed/core/translit.py tests/unit/core/test_name_romanization_roundtrip.py— passed.venv/bin/ruff format --check openmed/core/translit.py tests/unit/core/test_name_romanization_roundtrip.py— passedgit diff --check— passedAll test data and detector responses are synthetic and offline.
Closes #468