Skip to content

feat: Measure WAL and snapshot transfer speed#4183

Merged
as51340 merged 2 commits into
masterfrom
feat/monitoring-repl
May 29, 2026
Merged

feat: Measure WAL and snapshot transfer speed#4183
as51340 merged 2 commits into
masterfrom
feat/monitoring-repl

Conversation

@as51340
Copy link
Copy Markdown
Contributor

@as51340 as51340 commented May 27, 2026

Measure WAL and snapshot transfer speed. The intention is to measure if there is any drop in performance when using TLS sockets.

@as51340 as51340 added this to the mg-v3.11.0 milestone May 27, 2026
@as51340 as51340 requested a review from colinbarry May 27, 2026 09:58
@as51340 as51340 self-assigned this May 27, 2026
@as51340 as51340 added feature feature Docs needed Docs needed labels May 27, 2026
@as51340 as51340 force-pushed the feat/monitoring-repl branch from 4b65c99 to 6ad56bc Compare May 27, 2026 09:59
@as51340
Copy link
Copy Markdown
Contributor Author

as51340 commented May 27, 2026

Tracking

  • [Link to Epic/Issue]

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Users can now observe the WAL and snapshot transfer speed from the main's side. Metrics include the time needed for replicas to load durability files. #4183
    • What has changed? What does it mean for a user? What should a user do with it? [#{{PR_number}}]({{link to the PR}})
  • Documentation PR link
    • Is back linked to this development PR

@sonarqubecloud
Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Contributor

@colinbarry colinbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job - really easy to read code. 💪

I've left some notes on a few things, but nothing that should stop merge.

Comment thread src/storage/v2/inmemory/replication/recovery.hpp
Comment thread src/metrics/prometheus_metrics.hpp Outdated
Comment thread src/storage/v2/inmemory/replication/recovery.hpp Outdated
Comment thread src/metrics/prometheus_metrics.hpp Outdated
Comment thread src/metrics/prometheus_metrics.cpp Outdated
Comment thread src/metrics/prometheus_metrics.cpp
@as51340 as51340 force-pushed the feat/monitoring-repl branch from 6ad56bc to 152799f Compare May 29, 2026 07:35
@as51340 as51340 enabled auto-merge May 29, 2026 07:47
@as51340 as51340 added this pull request to the merge queue May 29, 2026
Merged via the queue into master with commit 37fdb09 May 29, 2026
38 checks passed
@as51340 as51340 deleted the feat/monitoring-repl branch May 29, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs needed Docs needed feature feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants