Skip to content

[OFF-873]: Close offline DB connection when navigating between pages #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolai-paramonov wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

[OFF-873]: Close offline DB connection when navigating between pages #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/jsActions/nanoflow-actions-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

- Close offline database connection before navigating between pages with OpenURL nanoflow action.

## [7.1.0] Nanoflow Commons - 2026-6-5

### Changed
Expand Down
1 change: 1 addition & 0 deletions packages/jsActions/nanoflow-actions-native/src/external/OpenURL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

// Native platform
if (navigator && navigator.product === "ReactNative") {
const Linking: typeof ReactNative.Linking = require("react-native").Linking;

Check warning on line 27 in packages/jsActions/nanoflow-actions-native/src/external/OpenURL.ts

View workflow job for this annotation

GitHub Actions / Unit tests 

Require statement not part of import statement

return Linking.canOpenURL(url).then(supported => {
if (!supported) {
Expand All @@ -42,6 +42,7 @@

// Web platform
if (window) {
await mx.data.closeDbConnection();

@nikolai-paramonov nikolai-paramonov Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation of the closeDbConnection https://gitlab.rnd.mendix.com/appdev/appdev/-/blob/master/client/src/core/Data.ts#L1781

window.location.href = url;
return Promise.resolve(true);
}
Expand Down
1 change: 1 addition & 0 deletions packages/jsActions/nanoflow-actions-native/typings/mx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ declare namespace mx {
}) => Promise<void>;
}
interface data {
closeDbConnection: () => Promise<void>;
update: (param: { guid?: string | undefined; entity?: string | undefined; callback?: () => void }) => void;
}
interface session {
Expand Down
Loading