Skip to content

[MOO-2370]: Bottomsheet stuttering and flickering (Android)#526

Open
MxKevinBeqo wants to merge 6 commits into
mx/11.6.xfrom
moo/MOO-2370-bottomsheet-stutter
Open

[MOO-2370]: Bottomsheet stuttering and flickering (Android)#526
MxKevinBeqo wants to merge 6 commits into
mx/11.6.xfrom
moo/MOO-2370-bottomsheet-stutter

Conversation

@MxKevinBeqo

Copy link
Copy Markdown
Contributor

Checklist

  • Contains unit tests ✅
  • Contains breaking changes ❌
  • Compatible with: MX 11
  • Did you update version and changelog? ✅
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅
  • Works in iOS ✅
  • Works in Tablet ✅

Feature specific

  • Comply with designs ✅
  • Comply with PM's requirements ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

This PR addresses an issue on Android where the BottomSheet would randomly stutter when toggling and/or cause background flickering.

Relevant changes

  • Refactored the layout calculations and initial rendering of the Modal.
  • Improved backdrop animation with smooth fade-in/fade-out transitions.

@MxKevinBeqo MxKevinBeqo self-assigned this Jun 19, 2026
@MxKevinBeqo MxKevinBeqo requested a review from a team as a code owner June 19, 2026 12:46
@MxKevinBeqo MxKevinBeqo added the bug Something isn't working label Jun 19, 2026
</BottomSheetScrollView>
</BottomSheet>
<Modal transparent animationType="none" visible={mounted} onRequestClose={close} onShow={handleModalShow}>
<GestureHandlerRootView style={{ flex: 1 }}>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now sure if this is correct since we already have root gesture view in client/src/ui/native/AppLoader.tsx

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the previous Pressable wrapper for the backdrop was used for this purpose. In theory the Backdrop pressBehavior="close" in conjunction with the GestureHandlerRootView would not require the Pressable. But perhaps the one we have in AppLoader is too 'far/high' in the tree for the backdrop to recognize...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Widget

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants