Test Suite Using Ginkgo - #7
Open
afzal-qxip wants to merge 18 commits into
Open
Conversation
akvlad
reviewed
Jun 2, 2025
akvlad
reviewed
Jun 4, 2025
akvlad
reviewed
Jun 10, 2025
| data | ||
| (struct { ResultType string "json:\"resultType\""; Result []e2e_tests.MatrixResult "json:\"result\"" }) { | ||
| ResultType: (string) (len=6) "matrix", | ||
| Result: ([]e2e_tests.MatrixResult) <nil> |
Contributor
There was a problem hiding this comment.
Pretty much all the tests have Result: ([]e2e_tests.MatrixResult) <nil> . That's wrong. The result should be non-nil
| var seriesResp SeriesResponse | ||
| err = json.Unmarshal(body, &seriesResp) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| err = cupaloy.New().SnapshotMulti( |
Contributor
There was a problem hiding this comment.
This snapshot should be for the response body as well. Not just for status.
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| Expect(resp.StatusCode).To(Equal(200)) | ||
| err = cupaloy.New().SnapshotMulti( |
Contributor
There was a problem hiding this comment.
This snapshot should be for the response body as well. Not just for status.
| resp, err := runRequest(fmt.Sprintf(`{test_id="%s"} | freq > 1 and (freq="4" or freq==2 or freq > 0.5)`, testID), 0, 0, 0, "", 0) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| adjustResult(resp, "", 0) | ||
| err = cupaloy.New().SnapshotMulti( |
Contributor
There was a problem hiding this comment.
This snapshot should be for the response body as well. Not just for status.
| Expect(err).NotTo(HaveOccurred()) | ||
| adjustResult(resp, "", 0) | ||
| err = cupaloy.New().SnapshotMulti( | ||
| "status", resp.Status, |
Contributor
There was a problem hiding this comment.
This snapshot should be for the response body as well. Not just for status.
| Expect(err).ToNot(HaveOccurred()) | ||
| defer resp.Body.Close() | ||
| Expect(resp.StatusCode).To(Equal(200)) | ||
| err = cupaloy.New().SnapshotMulti( |
Contributor
There was a problem hiding this comment.
Remove this snapshot check.
| Expect(err).ToNot(HaveOccurred()) | ||
| defer resp.Body.Close() | ||
| Expect(resp.StatusCode).To(Equal(200)) | ||
| err = cupaloy.New().SnapshotMulti( |
Contributor
There was a problem hiding this comment.
Remove this snapshot check.
| Expect(err).ToNot(HaveOccurred()) | ||
| defer resp.Body.Close() | ||
| Expect(resp.StatusCode).To(Equal(200)) | ||
| err = cupaloy.New().SnapshotMulti( |
Contributor
There was a problem hiding this comment.
Remove this snapshot check.
| Expect(err).ToNot(HaveOccurred()) | ||
| defer resp.Body.Close() | ||
| Expect(resp.StatusCode).To(Equal(200)) | ||
| err = cupaloy.New().SnapshotMulti( |
Contributor
There was a problem hiding this comment.
Remove this snapshot check.
| defer resp.Body.Close() | ||
| Expect(resp.StatusCode).To(Equal(401)) | ||
| } | ||
| err = cupaloy.New().SnapshotMulti( |
Contributor
There was a problem hiding this comment.
Remove this snapshot check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #6