Update Copilot formatting guidance with CI checks and CMake auto-fix steps#7885
Update Copilot formatting guidance with CI checks and CMake auto-fix steps#7885Copilot wants to merge 11 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/490c0f29-f328-442f-b280-591c6a302c40 Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/16102018-130f-491a-87f7-26ad84e003bf Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/944eaa0f-7d80-4808-b871-e5a88fd00c0e Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/0a183e74-f64f-4978-9771-7977aa95667e Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/b59a5b76-ce53-4ca6-a87f-bbd792a86407 Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/fb2c3354-e196-424f-8e7a-9d52825c3668 Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
|
@copilot where are the changes? |
cchost mentions across tests, samples, schema, and host configcchost mentions across tests, samples, schema, and host config
cchost mentions across tests, samples, schema, and host configmain) for stale cchost cleanup PR
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/700d0514-2e53-4921-8c30-587a02f8f30e Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
You’re right — there were no file changes before. I’ve now pushed |
|
@copilot adjust PR description, don't mention ant other PR, it's just a standalone task for the formatting guide. |
main) for stale cchost cleanup PR
Updated the PR description to keep it strictly as a standalone formatting-guide task and removed references to other PRs. No code changes were needed for this update (HEAD: |
| ## Code changes | ||
|
|
||
| - `ci-checks.sh` must run successfully before any commit is pushed. | ||
| - Always run `./scripts/ci-checks.sh` in the same way as CI before pushing. If it reports `CMake format` failures, run `./scripts/cmake-format-checks.sh -f` and re-run `./scripts/ci-checks.sh` before committing. |
There was a problem hiding this comment.
We have a whole skill for this here: https://github.com/microsoft/CCF/blob/main/.github/skills/formatting-and-linting.md, and we have a pointer to it here: https://github.com/microsoft/CCF/blob/main/.github/copilot-instructions.md#linting-and-formatting - surely we should at most point to this section, not repeat the content.
This change is a standalone formatting-guide update.
It adds explicit repository guidance for Copilot-driven changes to ensure formatting issues are caught and fixed consistently before push.
Formatting/CI guidance update
./scripts/ci-checks.shbefore pushing../scripts/cmake-format-checks.sh -f, then re-run./scripts/ci-checks.shbefore committing.Scope
.github/copilot-instructions.md).# Expected CMake-format remediation flow ./scripts/ci-checks.sh ./scripts/cmake-format-checks.sh -f ./scripts/ci-checks.sh