Remove stale cchost mentions across tests, samples, schema, and host config#7886
Closed
Copilot wants to merge 2 commits into
Closed
Remove stale cchost mentions across tests, samples, schema, and host config#7886Copilot wants to merge 2 commits into
cchost mentions across tests, samples, schema, and host config#7886Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/6b983d2a-191c-4ac1-b91b-473e3ba9df64 Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Remove stale cchost mentions across tests, samples, schema, and host config
Remove stale May 14, 2026
cchost mentions across tests, samples, schema, and host config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cchostbinary was removed in 7.x (each app is now its own executable), but stale references remained throughout the tree.Tests / infra (Python)
# Set to cchost default valuecomments with# Set to node default valueintests/infra/{runner,piccolo_driver}.py,tests/historical_query_{perf,cache}.py,tests/lts_compatibility.py.--binary-dirhelp text intests/infra/e2e_args.py.CCFRemote.BIN = ""class attribute and require the binary name on construction via a newbinary_namekwarg. Formajor_version >= 7(or unspecified) the binary isenclave_file; formajor_version < 7,binary_nameis asserted and resolved viabuild_bin_path.infra.node.Nodepassesbinary_name="cchost"for pre-7 nodes.Host config schema
doc/host_config_schema/cchost_config.json→host_config.json; updateCMakeLists.txtanddoc/conf.py.host::CCHostConfig→host::HostConfig(only used insrc/host/configuration.handsrc/host/run.cpp).samples/minimal_ccfmv .../bin/cchost /usr/bin/cchoststep in the runtime Dockerfile with amv .../bin/js_generic /usr/bin/js_genericstep, with a comment notingjs_genericis a sample binary intended to be replaced when adapting the image.cchostinvocation inrun_app.shwithjs_generic.cchost_config_virtual_js.json→config_virtual_js.json.Formatting
scripts/cmake-format-checks.sh -fto fixCMakeLists.txtformatting flagged by CI (collapsed thefile(READ ...)call onto a single line).Intentionally retained
CHANGELOG.mdhistorical entries.tests/infra/remote.py__init__explaining the 7.x binary consolidation (kept per review feedback).