Skip to content

Remove stale cchost mentions across tests, samples, schema, and host config#7886

Closed
Copilot wants to merge 2 commits into
copilot/remove-cchost-mentionsfrom
copilot/sub-pr-7883-again
Closed

Remove stale cchost mentions across tests, samples, schema, and host config#7886
Copilot wants to merge 2 commits into
copilot/remove-cchost-mentionsfrom
copilot/sub-pr-7883-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

The cchost binary was removed in 7.x (each app is now its own executable), but stale references remained throughout the tree.

Tests / infra (Python)

  • Replace # Set to cchost default value comments with # Set to node default value in tests/infra/{runner,piccolo_driver}.py, tests/historical_query_{perf,cache}.py, tests/lts_compatibility.py.
  • Update --binary-dir help text in tests/infra/e2e_args.py.
  • Remove the CCFRemote.BIN = "" class attribute and require the binary name on construction via a new binary_name kwarg. For major_version >= 7 (or unspecified) the binary is enclave_file; for major_version < 7, binary_name is asserted and resolved via build_bin_path. infra.node.Node passes binary_name="cchost" for pre-7 nodes.

Host config schema

  • Rename doc/host_config_schema/cchost_config.jsonhost_config.json; update CMakeLists.txt and doc/conf.py.
  • Rename C++ struct host::CCHostConfighost::HostConfig (only used in src/host/configuration.h and src/host/run.cpp).

samples/minimal_ccf

  • Replace the obsolete mv .../bin/cchost /usr/bin/cchost step in the runtime Dockerfile with a mv .../bin/js_generic /usr/bin/js_generic step, with a comment noting js_generic is a sample binary intended to be replaced when adapting the image.
  • Replace the cchost invocation in run_app.sh with js_generic.
  • Rename cchost_config_virtual_js.jsonconfig_virtual_js.json.

Formatting

  • Re-ran scripts/cmake-format-checks.sh -f to fix CMakeLists.txt formatting flagged by CI (collapsed the file(READ ...) call onto a single line).

Intentionally retained

  • CHANGELOG.md historical entries.
  • The inline comment in tests/infra/remote.py __init__ explaining the 7.x binary consolidation (kept per review feedback).

Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/6b983d2a-191c-4ac1-b91b-473e3ba9df64

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Remove stale cchost mentions across tests, samples, schema, and host config Remove stale cchost mentions across tests, samples, schema, and host config May 14, 2026
Copilot AI requested a review from maxtropets May 14, 2026 13:08
@maxtropets maxtropets closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants