Skip to content

Migrate indexing::LFS to task system, rather than ringbuffer #7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eddyashton wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Migrate indexing::LFS to task system, rather than ringbuffer #7955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4cf9f0
Remove indexing::LFS ringbuffer types, replace with ccf::tasks
eddyashton Jun 17, 2026
69e7bfe
Common flush_lfs
eddyashton Jun 17, 2026
3cf2308
Merge branch 'main' of https://github.com/microsoft/CCF into lfs_tasks
eddyashton Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/enclave/enclave.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ namespace ccf
context->install_subsystem(indexer);

lfs_access = std::make_shared<ccf::indexing::EnclaveLFSAccess>(
writer_factory->create_writer_to_outside());
ccf::tasks::get_main_job_board());
context->install_subsystem(lfs_access);

context->install_subsystem(std::make_shared<ccf::NodeOperation>(*node));
Expand Down Expand Up @@ -270,8 +270,6 @@ namespace ccf
// reconstruct oversized messages sent to the enclave
oversized::FragmentReconstructor fr(bp.get_dispatcher());

lfs_access->register_message_handlers(bp.get_dispatcher());

DISPATCHER_SET_MESSAGE_HANDLER(
bp, AdminMessage::stop, [this, &bp](const uint8_t*, size_t) {
bp.set_finished();
Expand Down
98 changes: 0 additions & 98 deletions src/host/lfs_file_handler.h
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions src/host/run.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include "host/files_cleanup_timer.h"
#include "http/curl.h"
#include "json_schema.h"
#include "lfs_file_handler.h"
#include "node_connections.h"
#include "pal/quote_generation.h"
#include "rpc_connections.h"
Expand Down Expand Up @@ -639,12 +638,6 @@ namespace ccf
config.files_cleanup.max_committed_ledger_chunks);
}

// handle LFS-related messages from the enclave
asynchost::LFSFileHandler lfs_file_handler(
writer_factory.create_writer_to_inside());
lfs_file_handler.register_message_handlers(
buffer_processor.get_dispatcher());

// Setup node-to-node connections
auto [node_host, node_port] =
cli::validate_address(config.network.node_to_node_interface.bind_address);
Expand Down
Loading
Loading