Basic AL4 support in CI by maxtropets · Pull Request #7972 · microsoft/CCF

maxtropets · 2026-06-24T18:48:57Z

Minimal AL4 support

run on demand with azure-linux-4 label
will also run nightly on main
currently builds with few deprecation warnings that are explicitly excluded from compiler werror-checks
- fix is incompatible with the current compiler version, so I left warning as is until we switch to AL4 and then implement the straightforward fix
runs unit + e2e tests (currently except partitions)
- instead of fixing on common code with macros/etc will build as is until fully switching to AL4

Copilot

Pull request overview

This PR introduces minimal Azure Linux 4 (AL4) coverage in CI (nightly on main and on-demand via the azure-linux-4 label) and makes a handful of small compatibility adjustments across C++, tests, and build tooling to get the codebase building and exercising unit/e2e tests on AL4.

Changes:

Add a new AL4 GitHub Actions workflow plus an AL4-specific dependency installation script.
Update a few code paths for AL4 toolchain/library differences (Arrow Parquet reader API, OpenSSL header deprecations, QUIC session member cleanup).
Minor test harness robustness tweaks (curl -m argument formatting, tolerate additional transient connection errors).

Custom instructions used:

.github/copilot-instructions.md
.github/instructions/reviewing.instructions.md

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`.github/workflows/ci-al4.yml`	Adds AL4 CI workflow with VMSS jobs to build and run unit/e2e buckets, with artifact upload of logs.
`scripts/setup-ci-al4.sh`	New AL4 bootstrap script installing build/test deps, Node, h2spec, and Python tooling (uv).
`tests/perf-system/submitter/submit.cpp`	Adds Arrow version gating for Parquet reader creation (Arrow ≥ 19 API change).
`tests/infra/clients.py`	Fixes curl timeout argument formatting by passing `-m` and its value as separate argv entries.
`tests/connections.py`	Expands transient exception handling to include `BrokenPipeError` during polling.
`src/quic/quic_session.h`	Removes redundant/shadowing `session_id` member in derived QUIC session type.
`src/enclave/enclave.h`	Drops OpenSSL `engine.h` include to align with OpenSSL 3 deprecations.
`include/ccf/crypto/openssl/openssl_wrappers.h`	Drops OpenSSL `engine.h` include from wrapper header.
`src/crypto/openssl/ec_public_key.cpp`	Drops OpenSSL `engine.h` include.
`src/crypto/openssl/ec_key_pair.cpp`	Drops OpenSSL `engine.h` include.
`src/ds/test/openapi.cpp`	Adds `std::hash<Baz>` specialization to enable schema generation for `std::unordered_set<Baz>`.
`src/crypto/openssl/hash.cpp`	Adjusts HKDF salt pointer handling for empty salts (review comment raised on semantics risk).
`samples/apps/logging/logging.cpp`	Simplifies unauthenticated caller detection by removing an unused `dynamic_cast` result variable.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

achamayou · 2026-07-03T10:25:14Z

 DECLARE_JSON_OPTIONAL_FIELDS(Baz, x, y);

+namespace std
+{


I am surprised we suddenly need this, do you know why?

achamayou · 2026-07-03T10:29:10Z

+      // and 3.5 both pass the pointer and salt_size through to HKDF, so no salt
+      // bytes are read and the derived key is unchanged.
+      const uint8_t empty_salt = 0;
+      const auto* salt_data = salt.empty() ? &empty_salt : salt.data();


Is it possible for the span to have a null ptr despite being non empty?

achamayou · 2026-07-03T10:30:17Z

+
+install_source_control() {
+    # Source control and tools used by this script.
+    tdnf -y install  \


I thought azl4 used dnf rather than tdnf? If we are going to split the script anyway, we might as well avoid aliases?

achamayou · 2026-07-03T10:31:19Z

+        libstdc++-devel
+    # Azure Linux 4 beta does not publish libbacktrace-static yet; the Azure
+    # Linux 3.0 RPM contains only backtrace.h and libbacktrace.a and works here.
+    tdnf install -y https://packages.microsoft.com/azurelinux/3.0/prod/base/x86_64/Packages/l/libbacktrace-static-13.2.0-7.azl3.x86_64.rpm


Can we request this asap, we've just added this as a dependency, and we do not want to have this hack for an indefinite period of time.

achamayou · 2026-07-03T10:32:36Z

+          git config --global --add safe.directory /__w/CCF/CCF
+          mkdir build
+          cd build
+          cmake -GNinja -DCMAKE_BUILD_TYPE=Debug "-DCMAKE_CXX_FLAGS=-Wno-error=deprecated-declarations -Wno-error=#warnings" ..


This feels like it should be in cmake, maybe gated on compiler version detection, but definitely not inline in the CI, this will make it too easy for local runs to diverge from CI.

achamayou · 2026-07-03T10:33:30Z

+
+jobs:
+  vmss-virtual-a:
+    if: &check_trigger_conditions ${{ (github.event.action == 'labeled' && github.event.label.name == 'azure-linux-4') || (github.event.action != 'labeled' && contains(github.event.pull_request.labels.*.name, 'azure-linux-4')) || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}


It seems to me that if the CI passes, we ought to run it every time and not use labels. Happy to discuss.

achamayou

A few questions, but LGTM.

maxtropets self-assigned this Jun 25, 2026

maxtropets force-pushed the f/al4-wip branch 11 times, most recently from b606ef9 to e990329 Compare July 1, 2026 16:45

maxtropets changed the title ~~[DRAFT] AL4 experiments~~ Basic AL4 support in CI Jul 1, 2026

Basic AL4 CI

a6d485f

maxtropets force-pushed the f/al4-wip branch from e990329 to a6d485f Compare July 1, 2026 16:46

maxtropets added the azure-linux-4 label Jul 1, 2026

Merge branch 'main' into f/al4-wip

e0883ac

maxtropets requested a review from Copilot July 2, 2026 07:57

Copilot started reviewing on behalf of maxtropets July 2, 2026 07:58 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread src/crypto/openssl/hash.cpp

maxtropets marked this pull request as ready for review July 2, 2026 08:06

maxtropets requested a review from a team as a code owner July 2, 2026 08:06

Upd salt

db83d07

maxtropets requested a review from Copilot July 2, 2026 11:54

Copilot started reviewing on behalf of maxtropets July 2, 2026 11:55 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread scripts/setup-ci-al4.sh

Fixup

268333f

maxtropets requested a review from Copilot July 2, 2026 15:56

Copilot started reviewing on behalf of maxtropets July 2, 2026 15:56 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread src/ds/test/openapi.cpp

maxtropets and others added 3 commits July 3, 2026 09:21

Merge branch 'main' into f/al4-wip

bef2a6d

Libtrace

80d28e1

Merge branch 'main' into f/al4-wip

2959e8b

achamayou reviewed Jul 3, 2026

View reviewed changes

achamayou approved these changes Jul 3, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Basic AL4 support in CI#7972

Basic AL4 support in CI#7972
maxtropets wants to merge 7 commits into
microsoft:mainfrom
maxtropets:f/al4-wip

maxtropets commented Jun 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

achamayou Jul 3, 2026

Uh oh!

achamayou Jul 3, 2026

Uh oh!

achamayou Jul 3, 2026

Uh oh!

achamayou Jul 3, 2026

Uh oh!

achamayou Jul 3, 2026

Uh oh!

achamayou Jul 3, 2026

Uh oh!

achamayou left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

maxtropets commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

achamayou Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

achamayou Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

achamayou Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

achamayou Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

achamayou Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

achamayou Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

achamayou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maxtropets commented Jun 24, 2026 •

edited

Loading