Remove jsrsasign from npm app#8020
Open
achamayou wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the jsrsasign dependency from the tests/npm-app package and updates the /app/crypto availability endpoint to check for the presence of CCF’s own @microsoft/ccf-app/crypto API instead. This keeps the npm test app aligned with the supported CCF crypto surface and reduces third-party crypto footprint in the test bundle.
Changes:
- Removed
jsrsasignand@types/jsrsasignfromtests/npm-app/package.json. - Updated the
/app/cryptoavailability check to use@microsoft/ccf-app/crypto(generateAesKey) rather thanjsrsasign.
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/npm-app/src/endpoints/crypto.ts | Replaces the availability canary check to rely on @microsoft/ccf-app/crypto (CCF-provided crypto API). |
| tests/npm-app/package.json | Drops jsrsasign and its types from dependencies/devDependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the jsrsasign dependency from the tests/npm-app test app.