Skip to content

Parse query parameters before URL-decoding#8024

Draft
achamayou with Copilot wants to merge 8 commits into
mainfrom
copilot/fix-query-params-ampersands
Draft

Parse query parameters before URL-decoding#8024
achamayou with Copilot wants to merge 8 commits into
mainfrom
copilot/fix-query-params-ampersands

Conversation

Copilot AI commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

CCF decoded the full query string before splitting on &, so escaped ampersands were treated as parameter separators. For example, ?bar%26baz=tom%26jerry could not produce bar&baz = tom&jerry.

  • Query handling

    • Preserve the raw query string on HttpRpcContext.
    • Split query parameters on raw & and =.
    • Decode each key/value component after splitting.
  • Regression coverage

    • Added parser coverage for escaped & and = in parameter names and values.
GET /foo?bar%26baz=tom%26jerry

is now parsed as:

bar&baz = tom&jerry

Copilot AI and others added 7 commits July 3, 2026 16:20
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix mis-parsing of query parameters with escaped ampersands Parse query parameters before URL-decoding Jul 3, 2026
Copilot AI requested a review from achamayou July 3, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query parameters containing (correctly-escaped) ampersands are mis-parsed by CCF

2 participants