feat(bundle): make 'anchors' the default bundle for new sessions#208
Merged
Conversation
Register `anchors` in WELL_KNOWN_BUNDLES (foundation subdirectory bundle bundles/anchors/bundle.md, pinned @main) and flip every hardcoded last-resort default fallback from "foundation" to "anchors": - commands/run.py (interactive session default) - runtime/config.py (resolve-config default) - commands/tool.py x2 (`amplifier tool` default) User-facing `amplifier bundle clear` messages and README updated to name anchors as the default. The default only applies when no bundle is explicitly configured, so: - New installs/sessions default to anchors. - Users who explicitly ran `amplifier bundle use foundation` are unaffected (their settings.bundle.active wins over the fallback). - In-flight/resumed sessions read their persisted bundle, not the fallback. - `amplifier bundle use foundation` still lets anyone keep foundation as default. PR 2 of 2. Depends on amplifier-foundation PR #259 (publishes bundles/anchors). Because the remote is pinned @main, this resolves correctly once #259 merges. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
…current display DTU validation surfaced two spots the initial default-flip missed: - commands/tool.py _should_use_bundle() still returned 'foundation' as the no-active-bundle default, so 'amplifier tool ...' invocations defaulted to foundation despite run/config already defaulting to anchors. - commands/bundle.py 'current' printed 'foundation (default)' and the 'use' tips said 'revert to default (foundation bundle)' — misreporting the default. Adds regression tests asserting _should_use_bundle() defaults to anchors and still honors an explicit active bundle. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
anchorsthe CLI's default bundle for new sessions.anchorsinWELL_KNOWN_BUNDLES->git+https://github.com/microsoft/amplifier-foundation@main#subdirectory=bundles/anchors/bundle.mdcommands/run.py(interactive session default)runtime/config.py(resolve-config default)commands/tool.pyx2 (amplifier tooldefault)amplifier bundle clearmessages + README to nameanchorsas the default.Why / behavior guarantees
The fallback only applies when no bundle is explicitly configured:
amplifier bundle use foundationamplifier bundle use foundation(unchanged)foundationand the original experiment are not deleted.PR 2 of 2 - depends on foundation PR #259
Requires microsoft/amplifier-foundation#259 (publishes
bundles/anchors/). The remote is pinned@main, so this resolves correctly once #259 merges. Merge #259 first.Tests
🤖 Generated with Amplifier