fix: add encoding='utf-8' to open() calls for non-English environments#7648
fix: add encoding='utf-8' to open() calls for non-English environments#7648goingforstudying-ctrl wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
@microsoft-github-policy-service agree |
|
Hi @microsoft autogen maintainers! 👋 Following up on this small fix that adds The CLA has been signed. Please let me know if any changes are needed or if there's a specific maintainer I should tag for review. Thanks! |
|
Hi @microsoft autogen maintainers! 👋 Following up on this small fix that adds The CLA has been signed and all security checks pass. This is a minimal, safe improvement. Please let me know if any changes are needed. Happy to address any feedback! |
- Add encoding='utf-8' to chat_completion_client_recorder.py read/write - Add encoding='utf-8' to page_logger.py write operations - Prevents UnicodeDecodeError on systems with non-UTF-8 default locale Fixes microsoft#5566
c218cea to
8966e4b
Compare
|
Hi @microsoft autogen maintainers! 👋 Following up on this small fix that adds The CLA has been signed and all security checks (GitGuardian, license/cla) pass. This fix prevents Please let me know if any changes are needed or if there's anything I can do to help move this forward! Thanks for maintaining AutoGen! 🙏 |
|
Hi @microsoft autogen maintainers! 👋 Just checking in on this PR — it's been about 8 days since opening and there hasn't been any maintainer feedback yet. Please let me know if:
Happy to make any adjustments needed! Thank you for your time. |
|
ใช้ NEXORA stack บน Windows locale ไทย |
|
Hi @nexoracontrol-ops! 👋 Thank you for testing this on a Thai Windows locale with the NEXORA stack! That's exactly the kind of environment where this fix matters most. Could you let me know if the Happy to make further adjustments if needed. |
|
Closing in favor of #7666 |
Summary
Adds
encoding='utf-8'toopen()calls inautogen-extto preventUnicodeDecodeErroron systems with non-UTF-8 default locale (e.g., Windows with cp950).Changes
chat_completion_client_recorder.py: addencoding='utf-8'to read/write of session filespage_logger.py: addencoding='utf-8'to HTML/hash file writesTest Plan
Fixes #5566