Refactor BulkDeleteController to simplify search parameter checks#5538
Open
jestradaMS wants to merge 2 commits into
Open
Refactor BulkDeleteController to simplify search parameter checks#5538jestradaMS wants to merge 2 commits into
jestradaMS wants to merge 2 commits into
Conversation
… enhance bulk delete handling during reindexing
…sure system-wide bulk delete requests succeed without preemptive checks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5538 +/- ##
==========================================
+ Coverage 77.02% 77.11% +0.08%
==========================================
Files 983 983
Lines 36007 36002 -5
Branches 5469 5469
==========================================
+ Hits 27736 27762 +26
+ Misses 6927 6896 -31
Partials 1344 1344 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the logic in
BulkDeleteControllerto avoid false-positive conflicts when handling system-wide bulk delete requests during a running reindex job. It removes unnecessary dependencies and simplifies the check for whether a delete request can affectSearchParameterresources. Additionally, a new unit test is added to ensure correct behavior.Related issues
Addresses AB#191051.
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)