Skip to content

Refactor BulkDeleteController to simplify search parameter checks#5538

Open
jestradaMS wants to merge 2 commits into
mainfrom
users/jestrada/fixbulkdeletesearchparamcheck
Open

Refactor BulkDeleteController to simplify search parameter checks#5538
jestradaMS wants to merge 2 commits into
mainfrom
users/jestrada/fixbulkdeletesearchparamcheck

Conversation

@jestradaMS
Copy link
Copy Markdown
Contributor

@jestradaMS jestradaMS commented May 1, 2026

Description

This pull request refactors the logic in BulkDeleteController to avoid false-positive conflicts when handling system-wide bulk delete requests during a running reindex job. It removes unnecessary dependencies and simplifies the check for whether a delete request can affect SearchParameter resources. Additionally, a new unit test is added to ensure correct behavior.

Related issues

Addresses AB#191051.

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

… enhance bulk delete handling during reindexing
@jestradaMS jestradaMS added this to the FY26\Q4\2Wk\2Wk22 milestone May 1, 2026
@jestradaMS jestradaMS requested a review from a team as a code owner May 1, 2026 20:08
@jestradaMS jestradaMS added Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs No-PaaS-breaking-change No-ADR ADR not needed labels May 1, 2026
…sure system-wide bulk delete requests succeed without preemptive checks
@jestradaMS jestradaMS added Bug Bug bug bug. labels May 1, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.11%. Comparing base (a894a3b) to head (93d17cd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5538      +/-   ##
==========================================
+ Coverage   77.02%   77.11%   +0.08%     
==========================================
  Files         983      983              
  Lines       36007    36002       -5     
  Branches     5469     5469              
==========================================
+ Hits        27736    27762      +26     
+ Misses       6927     6896      -31     
  Partials     1344     1344              

see 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. No-ADR ADR not needed No-PaaS-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants