Skip to content

Fix stale and incorrect entries in data dictionary#2112

Open
RolandKrummenacher wants to merge 2 commits intodevfrom
docs/data-dictionary-corrections
Open

Fix stale and incorrect entries in data dictionary#2112
RolandKrummenacher wants to merge 2 commits intodevfrom
docs/data-dictionary-corrections

Conversation

@RolandKrummenacher
Copy link
Copy Markdown
Collaborator

Summary

Audited the FinOps toolkit data dictionary against the FOCUS 1.2 schema in src/open-data/dataset-metadata/FocusCost_1.2-preview.json and fixed 10 demonstrably wrong or stale entries. Conservative pass — only fixing existing rows that are incorrect; no structural changes and no newly added columns.

Fixes

Row Issue
BilledCost Pre-FOCUS-1.0 wording; stale "include the Cost Management connector" guidance; CM-dataset mapping leaked Cost Management implementation detail into a FOCUS-aligned dictionary
BillingCurrency "Currency code for all price and cost columns" — wrong; it only applies to billing-amount columns. Pricing-amount columns use PricingCurrency
BillingProfileId / BillingProfileName Described as covering EA or MCA — billing profiles are MCA only. Also fixed "invoices invoices" typo
CommitmentDiscountQuantity Description was for the wrong column — copied from CommitmentDiscountType (a label). Replaced with FOCUS 1.2 wording (an amount denominated in CommitmentDiscountUnit)
EffectiveCost Loose "BilledCost spread across the term"; CM-dataset mapping removed for the same reason as BilledCost
ListUnitPrice Stale OnDemandUnitPrice reference (renamed to ContractedUnitPrice in v0.4)
PricingQuantity Stale UsageQuantity reference (renamed to ConsumedQuantity in v0.4)
PricingUnitDescription Grammar typo ("type is used by"); added FOCUS-aligned wording about pricing block size
TotalSavingsRunningTotal Was describing DiscountCostSavings (an alias) instead of TotalSavings

Also bumped ms.date to 04/29/2026.

Out of scope (potential follow-ups)

  • ~10 FOCUS 1.2 columns missing from the dictionary entirely (x_AccountId, x_BilledUnitPrice, x_ContractedCostInUsd, x_ServicePeriodStart/End, x_SkuDescription, x_SkuIsCreditEligible, x_SkuRegion)
  • IsCreditEligible may have been renamed to x_SkuIsCreditEligible in FOCUS 1.2 — needs hubs-output verification
  • SkuServiceFamily "as of February 2023, there's a bug for EA where it's always Compute" — three years stale, worth re-verifying
  • InvoiceIssuerName "Only supported for CSP accounts" — likely no longer true under FOCUS 1.2
  • Tags "Microsoft Cost Management has a bug where it's missing the outer braces" — possibly stale

Pre-existing alignment warning on the ServiceModel row (line 167) was not introduced by this PR and is left for a separate cleanup.

Test plan

  • Render the page locally / on a Learn preview and verify table layout is unchanged
  • Spot-check the corrected rows against FocusCost_1.2-preview.json and the FOCUS 1.2 spec
  • Confirm the page hasn't regressed in the docs-mirror pipeline (MicrosoftDocs/partner-center-pr)

Note: the live learn.microsoft.com page won't refresh until the docs mirror runs.

🤖 Generated with Claude Code

Several entries in the FinOps toolkit data dictionary were inaccurate or
referred to deprecated columns. Corrections in this commit:

- BilledCost / EffectiveCost: align descriptions with the FOCUS 1.2
  spec; remove ActualCost/AmortizedCost dataset references and the
  stale "include the Cost Management connector" guidance
- BillingCurrency: clarify it applies to billing-amount columns only
  (pricing-amount columns use PricingCurrency)
- BillingProfileId / BillingProfileName: correct as MCA-only
  (previously described as covering EA or MCA); fix "invoices invoices"
  typo
- CommitmentDiscountQuantity: replace incorrect description (was
  describing CommitmentDiscountType) with FOCUS 1.2 wording
- ListUnitPrice: replace stale OnDemandUnitPrice reference with
  ContractedUnitPrice (renamed in v0.4)
- PricingQuantity: replace stale UsageQuantity reference with
  ConsumedQuantity (renamed in v0.4)
- PricingUnitDescription: fix grammar typo and add FOCUS 1.2 wording
- TotalSavingsRunningTotal: was describing DiscountCostSavings; now
  correctly references TotalSavings

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants