Fix stale and incorrect entries in data dictionary#2112
Open
RolandKrummenacher wants to merge 2 commits intodevfrom
Open
Fix stale and incorrect entries in data dictionary#2112RolandKrummenacher wants to merge 2 commits intodevfrom
RolandKrummenacher wants to merge 2 commits intodevfrom
Conversation
Several entries in the FinOps toolkit data dictionary were inaccurate or referred to deprecated columns. Corrections in this commit: - BilledCost / EffectiveCost: align descriptions with the FOCUS 1.2 spec; remove ActualCost/AmortizedCost dataset references and the stale "include the Cost Management connector" guidance - BillingCurrency: clarify it applies to billing-amount columns only (pricing-amount columns use PricingCurrency) - BillingProfileId / BillingProfileName: correct as MCA-only (previously described as covering EA or MCA); fix "invoices invoices" typo - CommitmentDiscountQuantity: replace incorrect description (was describing CommitmentDiscountType) with FOCUS 1.2 wording - ListUnitPrice: replace stale OnDemandUnitPrice reference with ContractedUnitPrice (renamed in v0.4) - PricingQuantity: replace stale UsageQuantity reference with ConsumedQuantity (renamed in v0.4) - PricingUnitDescription: fix grammar typo and add FOCUS 1.2 wording - TotalSavingsRunningTotal: was describing DiscountCostSavings; now correctly references TotalSavings Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited the FinOps toolkit data dictionary against the FOCUS 1.2 schema in src/open-data/dataset-metadata/FocusCost_1.2-preview.json and fixed 10 demonstrably wrong or stale entries. Conservative pass — only fixing existing rows that are incorrect; no structural changes and no newly added columns.
Fixes
BilledCostBillingCurrencyPricingCurrencyBillingProfileId/BillingProfileNameCommitmentDiscountQuantityCommitmentDiscountType(a label). Replaced with FOCUS 1.2 wording (an amount denominated inCommitmentDiscountUnit)EffectiveCostBilledCostListUnitPriceOnDemandUnitPricereference (renamed toContractedUnitPricein v0.4)PricingQuantityUsageQuantityreference (renamed toConsumedQuantityin v0.4)PricingUnitDescriptionTotalSavingsRunningTotalDiscountCostSavings(an alias) instead ofTotalSavingsAlso bumped
ms.dateto04/29/2026.Out of scope (potential follow-ups)
x_AccountId,x_BilledUnitPrice,x_ContractedCostInUsd,x_ServicePeriodStart/End,x_SkuDescription,x_SkuIsCreditEligible,x_SkuRegion)IsCreditEligiblemay have been renamed tox_SkuIsCreditEligiblein FOCUS 1.2 — needs hubs-output verificationSkuServiceFamily"as of February 2023, there's a bug for EA where it's always Compute" — three years stale, worth re-verifyingInvoiceIssuerName"Only supported for CSP accounts" — likely no longer true under FOCUS 1.2Tags"Microsoft Cost Management has a bug where it's missing the outer braces" — possibly stalePre-existing alignment warning on the
ServiceModelrow (line 167) was not introduced by this PR and is left for a separate cleanup.Test plan
FocusCost_1.2-preview.jsonand the FOCUS 1.2 spec🤖 Generated with Claude Code