Make folder/directory terminology more consistent#64
Merged
Conversation
- Rename <database-dir> placeholder to <database-folder> throughout - Change 'directory' to 'folder' in prose, comments, descriptions - Update audit-chunks --dir to --folder in examples - Update JSON schema description fields - Keep established compounds: working-directory, working-dir - Keep vendor terms: LanceDB directory-based, Tantivy Directory
… comments - Update error messages from 'directory' to 'folder' per naming policy - Rename audit-chunks --dir flag to --folder - Update doc comments in init_db, fts, storage, and config modules - Keep established compounds (working directory, MmapDirectory) unchanged
…ifiers - Update comments from 'directory' to 'folder' across engine modules - Rename identifiers: fts_index_dir -> fts_index_folder, fts_dir -> fts_folder, fts_catalog_dir -> fts_catalog_folder, manifest_dir -> manifest_folder - Update test assertion messages and comments - Keep established compounds (working directory, MmapDirectory) unchanged
# Conflicts: # src/engine/git_ops/package_index.rs
- Rename fts_dir to fts_folder in integration test identifiers - Update comments and assertion messages from directory to folder - Fix cross-doc inconsistency: per-directory locks -> per-folder locks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update codebase to use a more consistent "folder vs directory" naming rule
One small breaking change:
audit-chunks --diris now--folder.