Add mod.rs facade policy#67
Merged
Merged
Conversation
Visibility sweep across app/, app/crawl/, app/commands/, engine/, engine/fts/, engine/git_ops/ to demote child module declarations from pub mod to plain mod, per the facade integrity policy in docs/code_organization_policy.md. - app/mod.rs: demote cli, context, crawl, search - app/commands/mod.rs: demote audit_chunks, debug_fts, dump_chunks, use_cmd, view - app/crawl/mod.rs: demote all children, add re-exports for crawl.rs facade reach - engine/mod.rs: demote 12 children, add re-exports for app/ facade reaches - engine/fts/mod.rs: demote all 6 children - engine/git_ops/mod.rs: demote commit, working_dir Re-export additions: - app/crawl/mod.rs: re-export items used by commands/crawl.rs - engine/mod.rs: re-export items used by app/ (git_ops, partitioner, etc.) Import rewrites in src/app/: - crawl.rs, phases.rs, preamble.rs, warning.rs - search.rs, tests.rs (search module) - config.rs, audit_chunks.rs, dump_chunks.rs - commands/search.rs (including test module) CI infrastructure: - scripts/check-facades.sh: enforce facade integrity with 12-entry allowlist - justfile: add check-facades recipe, wire into ci and ci-quick - .github/workflows/ci.yaml: add Check facade integrity step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update files to comply